Update annual process bill run to connect engine #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4379 > For context this came out of us working on re-implementing the SROC annual bill run using what we've learnt and components from our supplementary billing engine. We've been making a series of changes to our services in `app/services/bill-runs` in preparation for supporting creating annual bill runs. Primarily this has been refactoring services built for supplementary to be reused for annual billing. But it also involved adding the heart of the annual billing engine; `app/services/bill-runs/annual/process-billing-period.service.js`. Now we are ready to connect these changes to the request coming. That connection is managed by `app/services/bill-runs/annual/process-bill-run.service.js` which currently is just a place holder. This change updates it to handle orchestrating the billing process for annual bill runs.
Cruikshanks
force-pushed
the
update-annual-process-bill-run-service
branch
from
53eb681 to
04c870f
Compare
This should have been added to the example file when we added the CHA specific config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4379
We've been making a series of changes to our services in
app/services/bill-runsin preparation for supporting creating annual bill runs. Primarily this has been refactoring services built for supplementary to be reused for annual billing. But it also involved adding the heart of the annual billing engine;app/services/bill-runs/annual/process-billing-period.service.js.Now we are ready to connect these changes to the request coming. That connection is managed by
app/services/bill-runs/annual/process-bill-run.service.jswhich currently is just a placeholder. This change updates it to handle orchestrating the billing process for annual bill runs.