Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controls & validation for Rtn req setup page #758

Conversation

Demwunz
Copy link
Contributor

@Demwunz Demwunz commented Feb 23, 2024

https://eaflood.atlassian.net/browse/WATER-4267

This change adds controls and validation for the setup page.

Depending on which control is chosen, the user will be redirected to a different follow up page.

If nothing is selected the user is presented with a validation warning.

Demwunz and others added 13 commits February 14, 2024 19:21
Added setup page for return requirements journey. Step 3 of 7.
…quired-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
Comments were not complete, so had to amend them as per Roberts feedback
…quired-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
…quired-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
…quired-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
…quired-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
…quired-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7
@Demwunz Demwunz self-assigned this Feb 23, 2024
@Demwunz Demwunz marked this pull request as ready for review February 26, 2024 15:38
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most minor of NITs!

@Demwunz Demwunz requested a review from Cruikshanks February 27, 2024 10:09
@Demwunz
Copy link
Contributor Author

Demwunz commented Feb 27, 2024

Merged your suggestion @Cruikshanks ready for a re-review :)

@Demwunz Demwunz changed the title Returns required - How do you want to set up page (3 of 7) Add controls & validation for Rtn req setup page Feb 27, 2024
@Demwunz Demwunz merged commit a69525d into main Feb 27, 2024
6 checks passed
@Demwunz Demwunz deleted the WATER-4267-returns-required-journey-how-do-you-want-to-set-up-page-iteration-2-3-of-7 branch February 27, 2024 11:46
@Jozzey Jozzey added the enhancement New feature or request label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants