Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns required - Select an existing return requirement from basic page #746

Conversation

Demwunz
Copy link
Contributor

@Demwunz Demwunz commented Feb 20, 2024

This is a basic page layout for step 4 of 7 in the return requirements journey.

Validation will follow in a later ticket.

#WATER-4267 depends on this page.

https://eaflood.atlassian.net/browse/WATER-4282

This is a stub page.

This page is the basic skeleton for the 'Select an existing return requirement from' page.

This is step 4 in the return requirements journey.
…quired-journey-create-select-an-existing-return-requirement-from-page
@Demwunz Demwunz requested a review from Cruikshanks February 20, 2024 09:58
@Demwunz Demwunz marked this pull request as ready for review February 20, 2024 10:16
@Demwunz Demwunz self-assigned this Feb 20, 2024
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a NIT for the route description. But other than that it's all gravy!

app/routes/return-requirement.routes.js Outdated Show resolved Hide resolved
@Demwunz Demwunz merged commit 7cf1a32 into main Feb 20, 2024
6 checks passed
@Demwunz Demwunz deleted the WATER-4282-returns-required-journey-create-select-an-existing-return-requirement-from-page branch February 20, 2024 10:46
@Cruikshanks Cruikshanks added the enhancement New feature or request label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants