Refactor CreateBillingBatchService #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3854 To support our work on adding an endpoint that will allow us to create a new SROC bill run we need to refactor the existing `CreateBillingBatchService` a little bit! Some of the stuff it's currently defaulting we're now going to pass in. We also need it to bring back the instance with `.region` populated. This is to support creating the 'new' billing batch event record.
Cruikshanks
added
the
housekeeping
Now allows for some values to be overridden (though we still default them for ease). We also ensure that the instance which gets returned includes the populated region. Update the tests to reflect these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3854
To support our work on adding an endpoint that will allow us to create a new SROC bill run we need to refactor the existing
CreateBillingBatchServicea little bit!Some of the stuff it's currently defaulting we're now going to pass in. We also need it to bring back the instance with
.regionpopulated. This is to support creating the 'new' billing batch event record.