Remove abstraction text for under query licence #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4191 During the testing for the review licence page in a twp part tariff bill run, it was discussed in a blocker review the text for a return that is under query. Currently if a return is under query it shows a text box stating the return is either fully abstracted or over abstracted. This is wrong as a return that is under query is not allocated on the charge element and therefore does not meet any of those definitions. This change is to remove that text box for returns under query. This change also includes content changes on the page for unmatched returns. This is since an unmatched return would not be allocated to a charge element so we are removing the allocated text field.
Beckyrose200
deleted the
remove-abstraction-text-for-under-query-licence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4191
During the testing for the review licence page in a twp part tariff bill run, it was discussed in a blocker review the text for a return that is under query. Currently if a return is under query it shows a text box stating the return is either fully abstracted or over abstracted. This is wrong as a return that is under query is not allocated on the charge element and therefore does not meet any of those definitions. This change is to remove that text box for returns under query. This change also includes content changes on the page for unmatched returns. This is since an unmatched return would not be allocated to a charge element so we are removing the allocated text field.