Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display source of supply in view licence page summary tab #732

Merged
merged 12 commits into from
Feb 22, 2024

Conversation

robertparkinson
Copy link
Collaborator

https://eaflood.atlassian.net/browse/WATER-4327

Migrating the licence summary page from the water-abstraction-ui to the water-abstraction-system.

This PR adds the source of the supply onto the summary page

@Cruikshanks Cruikshanks added the enhancement New feature or request label Feb 20, 2024
@robertparkinson robertparkinson marked this pull request as ready for review February 21, 2024 12:16
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tweaks and then just some questions. Feel free to grab me if you want to get this over the line pronto!

app/models/licence.model.js Outdated Show resolved Hide resolved
test/services/licences/view-licence.service.test.js Outdated Show resolved Hide resolved
test/support/helpers/permit-licence.helper.js Outdated Show resolved Hide resolved
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertparkinson robertparkinson merged commit 0490b87 into main Feb 22, 2024
6 checks passed
@robertparkinson robertparkinson deleted the view-licence-summary-source-of-supply branch February 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants