Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return null when no name set for licence #723

Merged
merged 2 commits into from
Feb 12, 2024
Merged

return null when no name set for licence #723

merged 2 commits into from
Feb 12, 2024

Conversation

robertparkinson
Copy link
Collaborator

https://eaflood.atlassian.net/browse/WATER-4324

Unregistered licence should only be shown when there is no registered contact associated with the licence.

@robertparkinson robertparkinson marked this pull request as ready for review February 9, 2024 16:27
Cruikshanks
Cruikshanks approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertparkinson robertparkinson merged commit e52a95d into main Feb 12, 2024
6 checks passed
@robertparkinson robertparkinson deleted the view-licence-summary-registerd-to-name-bug branch February 12, 2024 09:01
@Beckyrose200 Beckyrose200 added the enhancement New feature or request label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cruikshanks Cruikshanks Cruikshanks approved these changes

Assignees

@robertparkinson robertparkinson

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertparkinson @Cruikshanks @Beckyrose200