Stop showing supp source charge as negative #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4363 We've just dealt with [Fix bill licence supp source decimal in wrong place](#714). This caused us to take a closer look at how the supported source charge is displayed in the new views. Our eagle eyed testers spotted we were showing the value as a negative if the transaction itself is a credit and whether this is correct. When we double checked the legacy view we found it's not! 🤦 This change fixes the display so the supported source charge is always displayed as a positive.
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
robertparkinson
approved these changes
Feb 9, 2024
Jozzey
approved these changes
Feb 9, 2024
Beckyrose200
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4363
We've just dealt with Fix bill licence supp source decimal in wrong place. This caused us to take a closer look at how the supported source charge is displayed in the new views.
Our eagle-eyed testers spotted we were showing the value as a negative if the transaction itself is a credit and whether this is correct. When we double-checked the legacy view we found it's not! 🤦
This change fixes the display so the supported source charge is always displayed as a positive.