Connect 2PT bill run request to match & allocate engine #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4343 At this point the the SROC 2PT bilI run is created with a status of `QUEUED` and then … nothing. We need to complete the final step, after creating the bill run water-abstraction-system now needs to `PROCESS` the bill run, triggering the new match & allocate engine, and updating the bill run status to `REVIEW` when it's complete. It also needs to handle marking the bill run as `ERRORED` should one be thrown, or `EMPTY` should there be no licences to bill.
This service was built as part of the supplementary billing engine but can be reused for all bill run types
Cruikshanks
requested changes
Feb 2, 2024
There was a problem hiding this comment.
I know it feels like a bit of a rewrite. But I'm rewriting the code @Cruikshanks wrote last year, not your code!
app/services/bill-runs/two-part-tariff/process-two-part-tariff-returns.service.js
Outdated
Show resolved
Hide resolved
app/services/bill-runs/two-part-tariff/process-two-part-tariff-returns.service.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
|
Sonarcloud is complaining about the length of the If we do any further refactoring of this function I think it will make it less clear what it is doing so I am going to override the SonarCloud issue for that particular service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4343
At this point the the SROC 2PT bilI run is created with a status of
QUEUEDand then … nothing.We need to complete the final step after creating the bill run.
water-abstraction-systemnow needs toPROCESSthe bill run, triggering the new match & allocate engine, and updating the bill run status toREVIEWwhen it's complete. It also needs to handle marking the bill run asERROREDshould one be thrown, orEMPTYshould there be no licences to bill.