Create review an individual licence for 2PT bill run #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4191 As part of our two-part tariff bill run work, we've developed a review page displaying a summary of all licences in a bill run. This PR allows you to click on a specific licence from the review page and review its details within the bill run.
Jozzey
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
I think we may be able to pull the data out of the DB so that it's in a format which will require less processing to get it into a state ready to pass to the view.
However, as discussed. This PR only covers the top portion of the screen. The next ticket, which is for the lower portion of the screen will require the query that is fetching the data to be updated. So any changes we make now may no longer be relevant once we start on the next ticket.
Therefore we may as well get this merged in and tested while we work on the lower portion of the screen and see what refactoring we can do once we have a clearer picture of how the final page is going to look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4191
As part of our two-part tariff bill run work, we've developed a review page displaying a summary of all licences in a bill run. This PR allows you to click on a specific licence from the review page and review its details within the bill run.