Fix objection models #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have found that we are not supporting schemas in the proper way and we haven't been using the correct case in our models.
Cruikshanks
approved these changes
Dec 21, 2022
Cruikshanks
added a commit
that referenced
this pull request
Dec 22, 2022
In a [previous change](#70) we had to fix our Objection implementation because we realised - our way of handling multiple schemas (using `tableName`) was [invalid](Vincit/objection.js#85 (comment)) - we were using the wrong case (snake vs camel) in most places. Under the hood Knex was fine, but once we leant into Objection relationships `withGraphFetched()` was bringing back nothing What this highlighted was our existing model tests weren't really doing anything. Sure, a query can get generated but till you run them and confirm a result you can't be sure they are working as expected. So, this change updates our model relationship tests to insert some data and confirm we get expected results back.
Merged
Cruikshanks
added a commit
that referenced
this pull request
Dec 22, 2022
In a [previous change](#70) we had to fix our Objection implementation because we realised - our way of handling multiple schemas (using `tableName`) was [invalid](Vincit/objection.js#85 (comment)) - we were using the wrong case (snake vs camel) in most places. Under the hood Knex was fine, but once we leant into Objection relationships `withGraphFetched()` was bringing back nothing What this highlighted was our existing model tests weren't really doing anything. Sure, a query can get generated but till you run them and confirm a result you can't be sure they are working as expected. So, this change updates our model relationship tests to insert some data and confirm we get expected results back.
Cruikshanks
added a commit
that referenced
this pull request
Dec 23, 2022
In a [previous change](#70) we had to fix our Objection implementation because we realised - our way of handling multiple schemas (using `tableName`) was [invalid](Vincit/objection.js#85 (comment)) - we were using the wrong case (snake vs camel) in most places. Under the hood Knex was fine, but once we leant into Objection relationships `withGraphFetched()` was bringing back nothing What this highlighted was our existing model tests weren't really doing anything. Sure, a query can get generated but till you run them and confirm a result you can't be sure they are working as expected. So, this change updates our model relationship tests to insert some data and confirm we get expected results back.
Cruikshanks
added a commit
that referenced
this pull request
Dec 23, 2022
In a [previous change](#70) we had to fix our Objection implementation because we realised - our way of handling multiple schemas (using `tableName`) was [invalid](Vincit/objection.js#85 (comment)) - we were using the wrong case (snake vs camel) in most places. Under the hood Knex was fine, but once we leant into Objection relationships `withGraphFetched()` was bringing back nothing What this highlighted was our existing model tests weren't really doing anything. Sure, a query can get generated but till you run them and confirm a result you can't be sure they are working as expected. So, this change updates our model relationship tests to insert some data and confirm we get the expected results back. **Notes - includes a couple of fixes in the models and how the relationships were defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found that we are not supporting schemas in the proper way and we haven't been using the correct case in our models.