-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display purposes in view licence page summary tab #682
Conversation
https://eaflood.atlassian.net/browse/WATER-4326 Migrating the licence summary page from the water-abstraction-ui to the water-abstraction-system. This ticket is for adding the purposes to the licence summary tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A request for an additional unit test, a correction in a comment and a suggestion to simplify something. All pretty minor hopefully.
The key feedback is a question; is it time to break up the presenter? 🤔
db/migrations/legacy/20240129145658_create-licence-version-purposes-table.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of changes in the unit test descriptions. Then all good!
https://eaflood.atlassian.net/browse/WATER-4326
Migrating the licence summary page from the water-abstraction-ui to the water-abstraction-system.
This ticket is for adding the purposes to the licence summary tab