Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display purposes in view licence page summary tab #682

Merged
merged 15 commits into from
Feb 5, 2024

Conversation

robertparkinson
Copy link
Collaborator

https://eaflood.atlassian.net/browse/WATER-4326

Migrating the licence summary page from the water-abstraction-ui to the water-abstraction-system.

This ticket is for adding the purposes to the licence summary tab

robertparkinson and others added 2 commits January 23, 2024 11:03
https://eaflood.atlassian.net/browse/WATER-4326

Migrating the licence summary page from the water-abstraction-ui to the water-abstraction-system.

This ticket is for adding the purposes to the licence summary tab
@robertparkinson robertparkinson self-assigned this Jan 26, 2024
@Cruikshanks Cruikshanks added the enhancement New feature or request label Jan 30, 2024
@robertparkinson robertparkinson marked this pull request as ready for review February 2, 2024 14:27
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A request for an additional unit test, a correction in a comment and a suggestion to simplify something. All pretty minor hopefully.

The key feedback is a question; is it time to break up the presenter? 🤔

Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of changes in the unit test descriptions. Then all good!

test/models/licence-version.model.test.js Outdated Show resolved Hide resolved
test/models/licence-version.model.test.js Outdated Show resolved Hide resolved
@robertparkinson robertparkinson merged commit fbf8833 into main Feb 5, 2024
6 checks passed
@robertparkinson robertparkinson deleted the view-licence-summary-purposes branch February 5, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants