Update 2PT /check endpoint with latest services #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
added
the
housekeeping
https://eaflood.atlassian.net/browse/WATER-4339 This follows on from [Update 2PT check endpoint with alternate changes](#582) where we applied the services we refactored out of our 2PT spike branch to the `/check` endpoint. The final set of services have now been refactored and added to `main`, so we can complete the work of replacing the stand-ins currently being used.
We can drop the PrepareLicences service and use the real one. However, when verifying the results we find it useful to see which lines were allocated to which elements. This is not something we care about when generating the review results for real. The problem is these can only happen deep inside the allocation process. We don't want to add toggles to the production service just for this. We're on the cusp of having the pages ready to go at which point we expect the `/check` endpoint to become defunct. So, for now we just copy the real service into our stand-ins and add the tweak which captures which lines were allocated.
Because the real services don't care about which lines got allocated they don't setup all charge elements to capture this. So, we have to amend the formatter to cater for matched returns without a `lines:` property.
One of the key tweaks was rather than each service iterating all the licences to be checked, one service iterates the licences and calls services that handle each of the steps for a single licence. So, we needed to update our `/check` endpoint service to do the same.
Cruikshanks
force-pushed
the
update-check-endpoint-with-latest
branch
from
63373c5 to
e748d55
Compare
|
SonarCloud rightly points out that the stand-ins and scenario formatted services could 'be improved'! But these are temporary modules only there until we have working review pages and the need for the I could overrule SonarCloud to get all green. But these issues should continue to be flagged until we remove these modules so I won't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4339
This follows on from Update 2PT check endpoint with alternate changes where we applied the services we refactored out of our 2PT spike branch to the
/checkendpoint.The final set of services has now been refactored and added to
main, so we can update the stand-ins service.We can also update the
TwoPartServiceto use the new way of working, iterating all licences in one place and passing each licence to the new services.We can drop the
PrepareLicencesfrom stand-ins and use the real one. However, when verifying the results we find it useful to see which lines were allocated to which elements. This is not something we care about when generating the review results for real.The problem is this can only happen deep inside the allocation process. We don't want to add toggles to the production service just for this. We're on the cusp of having the pages ready to go at which point we expect the
/checkendpoint to become defunct.So, for now, we just copy the real
AllocateReturnsToChargeElementServiceinto our stand-ins and add the tweak which captures which lines were allocated to it.