Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken licence agreement tear-down #673

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fix broken licence agreement tear-down #673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1268c7
Fix broken licence agreement tear-down
Cruikshanks Jan 19, 2024
a692fa0
Implement fix
Cruikshanks Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 37 additions & 26 deletions app/services/data/tear-down/water-schema.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ async function go () {
_financialAgreementTypes(),
_licenceVersionPurposes(),
_licenceVersions(),
_licences(),
_purposesPrimary,
_purposesSecondary(),
_purposesUses(),
Expand All @@ -35,7 +34,15 @@ async function go () {
_sessions()
])

return _regions()
// We have to do region and licence separate from the rest because they are the 'root' test records. The test data
// setup endpoint in water-abstraction-service will create the test region and licence records (plus others). The
// acceptance tests will then generate new data linked to these 'root' records, for example, new bill runs and licence
// agreements.
//
// These do not get flagged as `is_test`. So, to find them for deletion we have to join to the 'root' test records. If
// we included deleting these along with the other statements they could be deleted before statements like, delete
// from bill runs where region is 'test'.
return _regionsAndLicences()
}

async function _billingTransactions () {
Expand Down Expand Up @@ -229,6 +236,14 @@ async function _licenceAgreements () {
WHERE
"is_test" = TRUE;

DELETE
FROM
"water"."licence_agreements" AS "la"
USING "water"."licences" AS "l"
WHERE
"l"."is_test" = TRUE
AND "la"."licence_ref" = "l"."licence_ref";

ALTER TABLE water.licence_agreements ENABLE TRIGGER ALL;
`)
}
Expand Down Expand Up @@ -325,30 +340,6 @@ async function _licenceVersions () {
`)
}

async function _licences () {
return db.raw(`
ALTER TABLE water.licences DISABLE TRIGGER ALL;

DELETE
FROM
"water"."licences"
WHERE
"is_test" = TRUE;

ALTER TABLE water.licences ENABLE TRIGGER ALL;
`)
}

async function _regions () {
return db.raw(`
DELETE
FROM
"water"."regions"
WHERE
"is_test" = TRUE;
`)
}

async function _purposesPrimary () {
return db.raw(`
DELETE
Expand Down Expand Up @@ -421,6 +412,26 @@ async function _sessions () {
`)
}

async function _regionsAndLicences () {
return db.raw(`
ALTER TABLE water.licences DISABLE TRIGGER ALL;

DELETE
FROM
"water"."licences"
WHERE
"is_test" = TRUE;

DELETE
FROM
"water"."regions"
WHERE
"is_test" = TRUE;

ALTER TABLE water.licences ENABLE TRIGGER ALL;
`)
}

module.exports = {
go
}
Loading