Implement abstraction period query using Objection #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3862 We want to extract data on relevant charge versions, their references and abstraction periods from the DB. We’ll then use this to determine what extractions periods apply for a given charge version and billing period. The first step is getting the data out of the DB. We need to implement that query using our ORM Objection.
…query-using-objection
Cruikshanks
added a commit
that referenced
this pull request
Jan 10, 2023
https://eaflood.atlassian.net/browse/WATER-3834 In [Implement abstraction period query using Objection](#66) we amended the query used in `test/services/supplementary-billing/fetch-charge-versions.service.test.js` to include abstraction period information for each charge version candidate. We're aiming to get to a 'billable days' value but the next step is determining for each abstraction period, is it relevant to the current billing period, and if so, how much of it. This change implements a service which can be used to answer both those questions.
Jozzey
pushed a commit
that referenced
this pull request
Jan 19, 2023
https://eaflood.atlassian.net/browse/WATER-3834 In [Implement abstraction period query using Objection](#66) we amended the query used in `test/services/supplementary-billing/fetch-charge-versions.service.test.js` to include abstraction period information for each charge version candidate. We're aiming to get to a 'billable days' value but the next step is determining for each abstraction period whether it is relevant to the current billing period, and if so, how much of it. This change implements a service which can be used to answer both those questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3862
We want to extract data on relevant charge versions, their references and abstraction periods from the DB. We’ll then use this to determine what extractions periods apply for a given charge version and billing period.
The first step is getting the data out of the DB. We need to implement that query using our ORM Objection.