Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect rtns reqs start-date to correct journey #650

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

Cruikshanks
Copy link
Member

https://eaflood.atlassian.net/browse/WATER-4261

Having added support for the returns requirements set up journey session object to store which journey was selected (returns required or no returns required) it means we can now do things like enable the /start-date page to redirect to the correct next page. At the moment it only supports the no-returns required journey which means those testing the journey need to manually manipulate the URL.

We're about to begin work on adding the controls and validation for /start-date page in the returns requirements set-up journey. So, we expect this change to be updated as part of that. But till that is complete this change will allow our QA team to get on with checking other pages.

https://eaflood.atlassian.net/browse/WATER-4261

Having added [support for the returns requirements set up journey session object to store which journey was selected](#648) (returns required or no returns required) it means we can now do things like enable the `/start-date` page to redirect to the correct next page. At the moment it only supports the no returns required journey which means those testing the journey need to manually manipulate the URL.

We're about to begin work on [adding the controls and validation](#646) for `/start-date` page in the returns requirements set-up journey. So, we expect this change to be updated as part of that. But till that is complete this change will allow our QA team to get on with checking other pages.
@Cruikshanks Cruikshanks added the enhancement New feature or request label Jan 10, 2024
@Cruikshanks Cruikshanks self-assigned this Jan 10, 2024
@Cruikshanks Cruikshanks marked this pull request as ready for review January 10, 2024 20:58
@Cruikshanks Cruikshanks merged commit 85f6ce4 into main Jan 11, 2024
6 checks passed
@Cruikshanks Cruikshanks deleted the redirect-start-date-to-correct-journey branch January 11, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants