Licence Summary Page - Summary Tab #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating the licence summary page from the water-abstraction-ui to the water-abstraction-system. 1
Cruikshanks
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Woohoo! We are finally going to take on the mess that is the legacy view licence page! Fantastic start.
There are some changes I'd like to make (and more reasons to get off my 🍑 and update our conventions 🤦😩!) There are also some things I haven't thought of that are worth having a discussion about.
But there is an overall thought I think I have about the change. Currently, the service and presenter built treat the licence page and summary tab as one-and-the-same.
But when we come to the other tabs they will share some things currently being used, but not all.
So, is it worth at this stage splitting the work needed to fetch and present data for the licence page from that needed for the summary tab?
Cruikshanks
requested changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4311
Migrating the licence summary page from the water-abstraction-ui to the water-abstraction-system.