Amend bill count in bill run view for zero value #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4223 In testing of the new bill run view we've built a scenario was found where the count of bills we show didn't match with the number of bills on the page. For example, the bill run had 6 credit notes and 4 invoices so we displayed "10 Supplementary bills" as the caption. But when you counted the bills listed there were 11. We double checked what the legacy UI was doing with this bill run and found it too displayed 6 credits and 4 invoices. But its caption was "11 supplementary bills". Neither looks right! After digging in we found the extra bill is a 'zero-value' bill (where the credit and debit lines have value but they cancel each other out). These don't get sent to SSCL so are not included in the credit note and invoice count. After consultation with users they don't want these to be included in either the credit note or invoice count as this will mess up their reconciliation process. But they would like the total count to be correct. The agreed solution is that when a bill run contains zero-value bills we should extend the caption, for example "10 Supplementary bills and 1 zero value bill". This change implements that solution.
We are going to need it to check if there are any zero-value bills included and if so get the count.
Also make both be for supplementary (no idea why one was Annual before!)
If there is only 1 bill on a bill run it must be a credit or an invoice because a bill run won't exist with just one bill that is zero value. So, those tests are wrong and should not be included.
This will generate the correct caption for the view.
Means we get the thing we actually want in one call rather than doing it in 2 separate steps.
Cruikshanks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4223
In testing of the new bill run view we've built a scenario was found where the count of bills we show didn't match with the number of bills on the page.
For example, the bill run had 6 credit notes and 4 invoices so we displayed "10 Supplementary bills" as the caption. But when you counted the bills listed there were 11.
We double-checked what the legacy UI was doing with this bill run and found it also displayed 6 credits and 4 invoices. But its caption was "11 supplementary bills".
Neither looks right!
After digging in we found the extra bill is a 'zero value' bill (where the credit and debit lines have value but they cancel each other out). These don't get sent to SSCL so are not included in the credit note and invoice count.
After consultation with users, they don't want these to be included in the credit note or invoice count as this will mess up their reconciliation process. But they would like the total count to be correct. The agreed solution is that when a bill run contains zero-value bills we should extend the caption, for example, "10 Supplementary bills and 1 zero value bill".
This change implements that solution.