Move rtn req. routes and session handling #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having discussed and agreed a way forward for handling temporary sessions in our code base this demonstrates how we can create the initial session, then retrieve it in subsequent requests. The other thing it does is break the dependence on the return requirement journey sitting under `/licences`. `/licences` is still the gateway to the journey, creating the temporary session for tracking the journey. But it then redirects away so `/return-requirements` can take over. The benefit of this is without any additional controls, we have a way of 'clearing' the session. Essentially, the user simply has to leave the journey and start again and the session is cleared. But whilst in the journey the user can go forwards and backwards throughout and each page can validly assume `sessionId` refers to an existing record.
robertparkinson
changed the title
Demwunz
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
👍🏽
seems like there is one thing that needs to be fixed. - https://sonarcloud.io/code?id=DEFRA_water-abstraction-system&branch=lick-it-and-stick-it&selected=DEFRA_water-abstraction-system%3Aapp%2Fcontrollers%2Freturn-requirements.controller.js&line=138
Demwunz
suggested changes
Dec 19, 2023
| }) | ||
| } | ||
|
|
||
| async function saveReturnsHowDoYouWant (request, h) { |
There was a problem hiding this comment.
sonarcloud is complaining about this function being the same as saveNote
There was a problem hiding this comment.
I put in a small change to make it pass.
…tual saving of the data
Cruikshanks
previously approved these changes
Dec 19, 2023
Demwunz
previously approved these changes
Dec 19, 2023
robertparkinson
dismissed stale reviews from Demwunz and Cruikshanks
via
4a036e4
Cruikshanks
requested changes
Dec 19, 2023
app/plugins/auth.plugin.js
Outdated
| @@ -47,6 +47,7 @@ const AuthPlugin = { | |||
| }, | |||
| redirectTo: '/signin', | |||
| validate: async (_request, session) => { | |||
| console.log('🚀 ~ file: auth.plugin.js:50 ~ validate: ~ session:', session) | |||
There was a problem hiding this comment.
Doh! Something I should have spotted the first time around.
Suggested change
| console.log('🚀 ~ file: auth.plugin.js:50 ~ validate: ~ session:', session) |
There was a problem hiding this comment.
weird that it's showing up on my PR.. it's not something I added. but i've removed it now
Demwunz
pushed a commit
that referenced
this pull request
Dec 20, 2023
Having discussed and agreed a way forward for handling temporary sessions in our code base this demonstrates how we can create the initial session, then retrieve it in subsequent requests. The other thing it does is break the dependence on the return requirement journey sitting under `/licences`. `/licences` is still the gateway to the journey, creating the temporary session for tracking the journey. But it then redirects away so `/return-requirements` can take over. The benefit of this is without any additional controls, we have a way of 'clearing' the session. Essentially, the user simply has to leave the journey and start again and the session is cleared. But whilst in the journey the user can go forwards and backwards throughout and each page can validly assume `sessionId` refers to an existing record. --------- Co-authored-by: Alan Cruikshanks <[email protected]>
Demwunz
pushed a commit
that referenced
this pull request
Dec 20, 2023
Having discussed and agreed a way forward for handling temporary sessions in our code base this demonstrates how we can create the initial session, then retrieve it in subsequent requests. The other thing it does is break the dependence on the return requirement journey sitting under `/licences`. `/licences` is still the gateway to the journey, creating the temporary session for tracking the journey. But it then redirects away so `/return-requirements` can take over. The benefit of this is without any additional controls, we have a way of 'clearing' the session. Essentially, the user simply has to leave the journey and start again and the session is cleared. But whilst in the journey the user can go forwards and backwards throughout and each page can validly assume `sessionId` refers to an existing record. --------- Co-authored-by: Alan Cruikshanks <[email protected]>
Demwunz
pushed a commit
that referenced
this pull request
Dec 20, 2023
Having discussed and agreed a way forward for handling temporary sessions in our code base this demonstrates how we can create the initial session, then retrieve it in subsequent requests. The other thing it does is break the dependence on the return requirement journey sitting under `/licences`. `/licences` is still the gateway to the journey, creating the temporary session for tracking the journey. But it then redirects away so `/return-requirements` can take over. The benefit of this is without any additional controls, we have a way of 'clearing' the session. Essentially, the user simply has to leave the journey and start again and the session is cleared. But whilst in the journey the user can go forwards and backwards throughout and each page can validly assume `sessionId` refers to an existing record. --------- Co-authored-by: Alan Cruikshanks <[email protected]>
Demwunz
pushed a commit
that referenced
this pull request
Dec 20, 2023
Having discussed and agreed a way forward for handling temporary sessions in our code base this demonstrates how we can create the initial session, then retrieve it in subsequent requests. The other thing it does is break the dependence on the return requirement journey sitting under `/licences`. `/licences` is still the gateway to the journey, creating the temporary session for tracking the journey. But it then redirects away so `/return-requirements` can take over. The benefit of this is without any additional controls, we have a way of 'clearing' the session. Essentially, the user simply has to leave the journey and start again and the session is cleared. But whilst in the journey the user can go forwards and backwards throughout and each page can validly assume `sessionId` refers to an existing record. --------- Co-authored-by: Alan Cruikshanks <[email protected]>
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having discussed and agreed a way forward for handling temporary sessions in our code base this demonstrates how we can create the initial session, then retrieve it in subsequent requests.
The other thing it does is break the dependence on the return requirement journey sitting under
/licences./licencesis still the gateway to the journey, creating the temporary session for tracking the journey. But it then redirects away so/return-requirementscan take over.The benefit of this is without any additional controls, we have a way of 'clearing' the session. Essentially, the user simply has to leave the journey and start again and the session is cleared. But whilst in the journey the user can go forwards and backwards throughout and each page can validly assume
sessionIdrefers to an existing record.