Include volume in FetchChargeVersionsService#586

Merged

Cruikshanks merged 31 commits intomainfrom add-volume-to-fetch-charge-versions

Dec 15, 2023

+180-319

Commits on Dec 13, 2023

Include volume in FetchChargeVersionsService
Cruikshanks
committed
Boy scout - use a plural name to denote an array
Cruikshanks
committed
Boy scout - fix typos
Cruikshanks
committed
Boy scout - make billingPeriod a const
Cruikshanks
committed
Boy scout - order variables alphabetically
Cruikshanks
committed
Boy scout - remove unused region variable
Cruikshanks
committed
Fix - use of legacy field name
Cruikshanks
committed
Boy scout - remove repeated creation of chargeCat.
Cruikshanks
committed
Boy scout - compare directly in expect
Cruikshanks
committed
Boy scout - vars and beforeEach moved to top
Cruikshanks
committed
Boy scout - set the region code once at the top
Cruikshanks
committed
Boy scout - delete something already tested
Cruikshanks
committed
Boy scout - delete something already tested
Cruikshanks
committed
Boy scout - delete something already tested
Cruikshanks
committed
Boy scout - reuse existing setup for same test
Cruikshanks
committed
Boy scout - reorganise test blocks
Cruikshanks
committed
Boy scout - set the region code once at the top
Cruikshanks
committed
Boy scout - duplication of getting licence details
Cruikshanks
committed
Meant to remove this in a previous clean up
Cruikshanks
committed
Boy scout - add missing charge reference to test
Cruikshanks
committed
Oops! copy and paste error
Cruikshanks
committed
Boy scout - being consistent with rest of test
Cruikshanks
committed
Fix - purpose is not being set or tested
Cruikshanks
committed
Fix - not awaiting creation of ChargeCategory
Cruikshanks
committed

Commits on Dec 15, 2023

Merge branch 'main' into add-volume-to-fetch-charge-versions
Cruikshanks
authored
Fix typo

Cruikshanks
and
Jozzey
authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include volume in FetchChargeVersionsService#586

Commits on Dec 13, 2023

Include volume in FetchChargeVersionsService

Boy scout - use a plural name to denote an array

Boy scout - fix typos

Boy scout - make billingPeriod a const

Boy scout - order variables alphabetically

Boy scout - remove unused region variable

Fix - use of legacy field name

Boy scout - remove repeated creation of chargeCat.

Boy scout - compare directly in expect

Boy scout - vars and beforeEach moved to top

Boy scout - set the region code once at the top

Boy scout - delete something already tested

Boy scout - delete something already tested

Boy scout - delete something already tested

Boy scout - reuse existing setup for same test

Boy scout - reorganise test blocks

Boy scout - set the region code once at the top

Boy scout - duplication of getting licence details

Meant to remove this in a previous clean up

Boy scout - add missing charge reference to test

Oops! copy and paste error

Boy scout - being consistent with rest of test

Fix - purpose is not being set or tested

Fix - not awaiting creation of ChargeCategory

Commits on Dec 14, 2023

Boy scout - test charge category values

Boy scout - remove start date

Fix - test of order wasn't testing the order

Remove unneeded values

Merge branch 'main' into add-volume-to-fetch-charge-versions

Commits on Dec 15, 2023

Merge branch 'main' into add-volume-to-fetch-charge-versions

Fix typo