Add requirements approved page (return requirements) #580
Conversation
Demwunz
force-pushed
the
WATER-4251
branch
3 times, most recently
from
3fce15d to
8008847
Compare
| selectReturnStartDate, | ||
| requirementsApproved |
There was a problem hiding this comment.
To help those who get anxious about this kind of thing and to avoid the rest of us having to expend any effort we try and have some guidance on how to order things.
We have one for the top of JS files, and when I find the time I'll write up ones for functions and require() ordering.
The long and short of it is that we go alphabetically.
| selectReturnStartDate, | |
| requirementsApproved | |
| requirementsApproved, | |
| selectReturnStartDate |
So, just a minor tweak. 😁
There was a problem hiding this comment.
no problem, updated
| <h2 class="govuk-heading-m">What happens next</h2> | ||
| <p class="govuk-body">These return requirements are now active and returns will be opened for this licence in the next returns cycle.</p> | ||
| <p class="govuk-body"><a href="{{rootLink}}" class="govuk-link">Return to licence set up</a></p> | ||
| {% endblock %} |
There was a problem hiding this comment.
If only to avoid this scary-looking glyph, we ensure all files end with a newline.
If it helps there is a setting you can enable in VSCode to ensure this always happens when you save a file, "files.insertFinalNewline": true,. We have a few suggested VSCode settings folks might want to enable. Check out any of the *.settings.json files in docs/vscode to see them. You can also run 🌈 Settings in wal-dev-environment to have these settings applied to all the repos.
| {% endblock %} | |
| {% endblock %} | |
There was a problem hiding this comment.
Ok, I normally have this set to true or get eslint to catch in pre-commit hooks.
Added in new line :)
| @@ -71,4 +71,23 @@ describe('Licences controller', () => { | |||
| }) | |||
| }) | |||
| }) | |||
| describe('GET /licences/{id}/requirements-approved', () => { | |||
There was a problem hiding this comment.
Just to break up the tests, we use a bit of whitespace to separate them.
| describe('GET /licences/{id}/requirements-approved', () => { | |
| describe('GET /licences/{id}/requirements-approved', () => { |
https://eaflood.atlassian.net/browse/WATER-4251 This change adds a returns approved confirmation page to the end of the "no return requirements" journey. This is the last page in the journey. This is just a stub page.
https://eaflood.atlassian.net/browse/WATER-4251 This change adds a returns approved confirmation page to the end of the "no return requirements" journey. This is the last page in the journey. This is just a stub page.
https://eaflood.atlassian.net/browse/WATER-4251
This change adds a returns approved confirmation page to the end of the "no return requirements" journey.
This is the last page in the journey.
This is just a stub page.