Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New charge category model for SROC supplementary bill run #57

Merged
merged 10 commits into from
Dec 16, 2022

Conversation

Jozzey
Copy link
Contributor

@Jozzey Jozzey commented Dec 16, 2022

https://eaflood.atlassian.net/browse/WATER-3861

Behind the scenes, the charge references are held in the billing_charge_categories table. It is a lookup table as the references are static. They are linked to a charge version via the charge_elements table.

https://eaflood.atlassian.net/browse/WATER-3861

Behind the scenes, the charge references are held in the billing_charge_categories table. It is a lookup table as the references are static. They are linked to a charge version via the charge_elements table.
@Jozzey Jozzey added the enhancement New feature or request label Dec 16, 2022
@Jozzey Jozzey self-assigned this Dec 16, 2022
@Jozzey Jozzey marked this pull request as ready for review December 16, 2022 12:38
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just one of the relationships needs double checking 🤷

app/models/billing-charge-category.model.js Outdated Show resolved Hide resolved
@Jozzey Jozzey requested a review from Cruikshanks December 16, 2022 15:11
@Jozzey Jozzey merged commit 540a998 into main Dec 16, 2022
@Jozzey Jozzey deleted the charge-category-model-for-sroc-supp-bill-run branch December 16, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants