Refactor to use new view based CRM_V2 models #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4057 As part of the work we have been doing on two-part tariff, we will be creating all our new tables in the default `public` schema. We have also decided that when there is a legacy table that we are still going to need we will create a [View](https://www.postgresql.org/docs/current/sql-createview.html) of it in the `public` schema. This allows us to correct any issues with naming conventions, strip out unused fields, and join entities currently sat in different schemas. The first example of this approach was done in PR #531 . We created the new views in [Create CRM_V2 schema views](#556). Then in [Create CRM_V2 schema models and helpers](#561) we added the new models and helpers that use them. This is the final step in the process, we are refactoring any use of the legacy models to use the new ones and deleting all the legacy-based code.
Cruikshanks
added
the
housekeeping
Cruikshanks
force-pushed
the
refactor-to-use-new-crm-v2-models
branch
from
415f3aa to
84ad2da
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/services/bill-runs/supplementary/fetch-previous-transactions.service.test.js
Dismissed
Show dismissed
Hide dismissed
we also deal with a number of uses of the old naming for variables within the code.
Cruikshanks
force-pushed
the
refactor-to-use-new-crm-v2-models
branch
from
84ad2da to
a1c8ab0
Compare
Co-authored-by: Jason Claxton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4057
As part of the work we have been doing on two-part tariff, we will be creating all our new tables in the default
publicschema.We have also decided that when there is a legacy table that we are still going to need we will create a View of it in the
publicschema. This allows us to correct any issues with naming conventions, strip out unused fields, and join entities currently sat in different schemas. The first example of this approach was done in PR #531 .We created the new views in Create CRM_V2 schema views. Then in Create CRM_V2 schema models and helpers we added the new models and helpers that use them.
This is the final step in the process, we are refactoring any use of the legacy models to use the new ones and deleting all the legacy-based code.