Fix billing acc. address error when town is empty #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4231 Spotted whilst trying to change the billing account address locally. We were adding an FAO to a billing account address that turns out didn't have the `town` field populated. When we tried to confirm the change we kept getting an error from the `ChargingModuleCreateCustomerChangePresenter`. After looking into it `town` was a property we were passing to our `_truncate()` method without first checking if the value existed. We also didn't have a unit test covering this scenario. This change fixes the presenter and adds the missing unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix billing acc. address error when town is empty
https://eaflood.atlassian.net/browse/WATER-4231
Spotted whilst trying to change the billing account address locally. We were adding an FAO to a billing account address that turns out didn't have the
townfield populated. When we tried to confirm the change we kept getting an error from theChargingModuleCreateCustomerChangePresenter.After looking into it
townwas a property we were passing to our_truncate()method without first checking if the value existed. We also didn't have a unit test covering this scenario.This change fixes the presenter and adds the missing unit test.