Add new view bill run endpoint and template #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4223 We have been working on implementing a new version of the bill page. The current one tries to display all transaction details for all licences on a single page when the bill is selected. In the larger annual bill runs this might equate to more than 150 licences and their transactions which means the page is failing to load. All that work has been done in this repo as part of our ongoing efforts to migrate away from the legacy code. It is in the final throws of testing and will soon be released. To get to the new pages you have to pass through the existing bill run summary page. What our work has highlighted is this page leaves a lot to desire! Again, the larger the bill run the slower it is, noticeably so. Though it at least always loads 🧌. It also is inconsistent. It has a different layout depending on the bill run type, and one of those depends on tabs which is an incorrect use of the component (and 🤢). So, we want to remove this remaining 'bump' in our billing user journey and replace it with a 'better' one. This is the final change in a series to support that, which adds the new template and endpoint.
Cruikshanks
force-pushed
the
add-new-bill-run-page
branch
from
2c4af0e to
7bed8f4
Compare
Forgot to update the links to point to the new page rather than the legacy one!
Another thing we missed. Because of how much we are trying to display in our tables we have to add our own custom widths that go a little smaller than the ones provided by the design system (`one-quarter` is the smallest they go to). These are needed in the bill run page when we have both tables visible and want to ensure the columns for both line up. Added to that supplementary bills feature an extra column hence the need for 3 custom widths.
|
Work is still ongoing on this. We have found an issue with the counts on the page but the legacy view also seems to show confusing numbers! So, we're just waiting on design to come up with an agreed solution which is going to mean changes are needed. |
I'm going to implement the solution to the count issue in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4223
We have been working on implementing a new version of the bill page. The current one tries to display all transaction details for all licences on a single page when the bill is selected.
In the larger annual bill runs this will equate to more than 150 licences and their transactions, which means the page is failing to load.
All that work has been done in this repo as part of our ongoing efforts to migrate away from the legacy code. It is in the final throws of testing and will soon be released.
To get to the new pages you have to pass through the existing bill run summary page. What our work has highlighted is this page leaves a lot to desire! Again, the larger the bill run the slower it is, noticeably so. Though it at least always loads 🧌.
It also is inconsistent. It has a different layout depending on the bill run type, and one of those depends on tabs, which is an incorrect use of the component (and 🤢).
So, we want to remove this remaining 'bump' in our billing user journey and replace it with a 'better' one. This is the final change in a series to support that, which adds the new template and endpoint.