Remove back-link nunjucks includes #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4131 We created a generic back-link includes file for our Nunjucks template as part of building the new billing pages. It was initially built when we thought the requirement was to return users back to where they came from. But working with our designers we're all agreed that back-links in the service should take users to specific places. They should _not_ just be a stand-in for the browser back button. This means we never intend to use this includes file and we don't want those unaware of this decision to inadvertently make use of it. So, this change yeet's it from the codebase!
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4131
We created a generic back-link includes file for our Nunjucks template as part of building the new billing pages. It was initially built when we thought the requirement was to return users back to where they came from. But working with our designers we've all agreed that back-links in the service should take users to specific places. They should not just be a stand-in for the browser back button.
This means we never intend to use this includes file and we don't want those unaware of this decision to inadvertently make use of it. So, this change yeet's it from the codebase!