Refactor existing service to create a new one #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4188 As part of the work we have been doing on two-part-tariff. We have found some code that we created for supplementary billing can be re-used for 2PT. This PR will move the code from the `CalculateAuthorisedAndBillableDaysService` that is responsible for determining the abstraction period, and move it to a new service `DetermineAbstractionPeriodService`. Once extracted out this function can then also be used by the 2PT process as well as supplementary.
14 tasks
|
SonarCloud failing due to duplicated lines. This is due to the refactoring we are currently doing on 2PT and will not be an issue once complete. |
Cruikshanks
requested changes
Nov 19, 2023
app/services/bill-runs/determine-abstraction-periods.service.js
Outdated
Show resolved
Hide resolved
app/services/bill-runs/determine-abstraction-periods.service.js
Outdated
Show resolved
Hide resolved
test/services/bill-runs/determine-abstraction-periods.service.test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4188
As part of the work we have been doing on two-part-tariff. We have found some code that we created for supplementary billing can be re-used for 2PT.
This PR will move the code that is responsible for determining the abstraction period from the
CalculateAuthorisedAndBillableDaysService, and move it to a new serviceDetermineAbstractionPeriodService.Once extracted out this function can then also be used by the 2PT process as well as supplementary.