Fix bill total wrapping when a credit #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4131 We have found when the value of a credit gets beyond a few pounds that the current view will wrap it even though there appears to be plenty of space. So, in this change we tweak the [GDS layout class](https://design-system.service.gov.uk/styles/layout/#common-layouts) being used to give us a little extra space. The value will still wrap if it's _really_ large. But in most cases now it should be on one line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4131
We have found when the value of a credit gets beyond a few pounds that the current view will wrap it even though there appears to be plenty of space.
So, in this change, we tweak the GDS layout class being used to give us a little extra space. The value will still wrap if it's really large. But in most cases now it should be on one line.
Before
After