Rename services/billing to bill-runs #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was noted during a pairing session that the name `app/services/billing` is inconsistent with our current convention. For example, we have a `/bills` endpoint determined by `bills.routes.js`. Requests to that endpoint are handled by `bills.controller.js` which in turn refers to services in `app/services/bills`. The `/bill-runs` endpoint follows this convention until you get to the services folder. Then everything it references is found in `app/services/billing`. We know why this is; handling SROC supplementary billing was our first major feature on this service and _everything_ seemed to be called **BillingSomething**! But as we are in the process of delivery our next major billing feature (two-part tariff bill runs) now seems a good time to correct the folder name and make it consistent.
Cruikshanks
added
the
housekeeping
Cruikshanks
added a commit
that referenced
this pull request
Nov 22, 2023
It was spotted that `app/services/billing` was inconsistent with our naming convention so we [sorted that](#516). Only we didn't spot that `services/billing` was using things in `presenters/billing`. Doh! So, this change also corrects the presenters folder to, hopefully, get everything inline.
Cruikshanks
added a commit
that referenced
this pull request
Nov 22, 2023
It was spotted that `app/services/billing` was inconsistent with our naming convention so we [sorted that](#516). Only we didn't spot that `services/billing` was using things in `presenters/billing`. Doh! So, this change also corrects the presenters folder to, hopefully, get everything in line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noted during a pairing session that the name
app/services/billingis inconsistent with our current convention.For example, we have a
/billsendpoint determined bybills.routes.js. Requests to that endpoint are handled bybills.controller.jswhich in turn refers to services inapp/services/bills.The
/bill-runsendpoint follows this convention until you get to the services folder. Then everything it references is found inapp/services/billing.We know why this is; handling SROC supplementary billing was our first major feature on this service and everything seemed to be called BillingSomething!
But as we are in the process of delivery our next major billing feature (two-part tariff bill runs) now seems a good time to correct the folder name and make it consistent.