Add new single licence bill templates #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4132 In WATER-4155 and WATER-4156 we built 2 new pages for displaying a bill. WATER-4155 covered a new bill page that displayed details about the bill, the bill run it is in, and its billing account. It then listed all licences connected to the bill. Each licence if selected would take you to a new bill-licence page (WATER-4156 ) which displays the transactions for that licence in detail. This fixed the issue (WATER-4070 ) with the legacy code being unable to display licences with large (100s) numbers of licences. But what if a bill has just 1 licence? In this case, the team agreed to showing a table for 1 licence and requiring a user to click through for the details was superfluous. So, WATER-4132 is about building a page for that scenario; a bill with just 1 licence. In this change, we add the new templates needed to do this along with changes to the controller and ViewBillService to determine which template to show.
If we extended the way of testing the service we were currently using we'd need many hundreds of lines of fake data. We have extensive tests of the presenters and fetch services already so this seemed unnecessary. So, instead we opted to switch to the approach used in test/services/bill-licences/view-bill-licence.service.test.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4132
In WATER-4155 and WATER-4156 we built 2 new pages for displaying a bill. WATER-4155 covered a new bill page that displayed details about the bill, the bill run it is in, and its billing account. It then listed all licences connected to the bill.
Each licence if selected would take you to a new bill-licence page (WATER-4156 ) which displays the transactions for that licence in detail. This fixed the issue (WATER-4070 ) with the legacy code being unable to display licences with large (100s) numbers of licences.
But what if a bill has just 1 licence? In this case, the team agreed that showing a table for 1 licence and requiring a user to click through for the details was superfluous.
So, WATER-4132 is about building a page for that scenario; a bill with just 1 licence. In this change, we add the new templates needed to do this along with changes to the controller and ViewBillService to determine which template to show.