Add view bill licence service #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4156 Related to WATER-4155 and the work to replace the legacy bill page with our own we're now starting to build the page it will link to; a view of the bill licence and all its transactions. We've already made several other changes to support this. This change adds a new service that orchestrates fetching the information needed ([Add new fetch bill licence service](#501)), passing it through to a presenter ([Add View bill licence presenter](#508)) and returning the result.
Cruikshanks
added a commit
that referenced
this pull request
Nov 6, 2023
https://eaflood.atlassian.net/browse/WATER-4156 Related to WATER-4155 and the work to replace the legacy bill page with our own we're now able to add the page it will link to; a view of the bill licence and all its transactions. We've already made several other changes to support this. With the addition of [Add view bill licence service](#509) we can make the final change; creating the endpoint and adding the view template.
Cruikshanks
added a commit
that referenced
this pull request
Nov 6, 2023
https://eaflood.atlassian.net/browse/WATER-4156 Related to WATER-4155 and the work to replace the legacy bill page with our own we're now able to add the page it will link to; a view of the bill licence and all its transactions. We've already made several other changes to support this. With the addition of [Add view bill licence service](#509) we can make the final change; creating the endpoint and adding the view template.
Cruikshanks
added a commit
that referenced
this pull request
Nov 6, 2023
https://eaflood.atlassian.net/browse/WATER-4156 Related to WATER-4155 and the work to replace the legacy bill page with our own we're now able to add the page it will link to; a view of the bill licence and all its transactions. We've already made several other changes to support this. With the addition of [Add view bill licence service](#509) we can make the final change; creating the endpoint and adding the view template. --- Note about splitting the template We could have had 1 template and used `{% if %}` blocks to determine what to show based on whether we are dealing with a PRESROC or SROC bill licence. But the page is already complex enough cramming different content into different cells of a table without this extra headache. So, in this case, we've opted for separate templates and left the controller to decide which view to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4156
Related to WATER-4155 and the work to replace the legacy bill page with our own we're now starting to build the page it will link to; a view of the bill licence and all its transactions.
We've already made several other changes to support this. This change adds a new service that orchestrates fetching the information needed (Add new fetch bill licence service), passing it through to a presenter (Add View bill licence presenter) and returning the result.