Add new Minimum Charge Transaction presenter #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4156 Related to WATER-4155 and the work to replace the legacy bill page with our own we're now starting to build the page it will link to; a view of the bill licence and all its transactions. This adds a presenter that given a `TransactionModel` instance whose charge type is `minimum_charge` will return an object containing formatted details about the transaction. The presenter doesn't need to make any distinction between PRESROC and SROC transactions as they are both displayed in the same way.
Cruikshanks
added a commit
that referenced
this pull request
Nov 6, 2023
Related to WATER-4155 and the work to replace the legacy bill page with our own we're now starting to build the page it will link to; a view of the bill licence and all its transactions. We added presenters for each of the transaction types - [Minimum Charge Transaction presenter](#505) - [Compensation Charge Transaction presenter](#506) - [Standard Charge Transaction presenter](#507) Now we add a presenter that brings those together with details about the bill and bill run.
Cruikshanks
added a commit
that referenced
this pull request
Nov 6, 2023
https://eaflood.atlassian.net/browse/WATER-4156 Related to WATER-4155 and the work to replace the legacy bill page with our own we're now starting to build the page it will link to; a view of the bill licence and all its transactions. We added presenters for each of the transaction types - [Minimum Charge Transaction presenter](#505) - [Compensation Charge Transaction presenter](#506) - [Standard Charge Transaction presenter](#507) Now we add a presenter that brings those together with details about the bill and bill run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4156
Related to WATER-4155 and the work to replace the legacy bill page with our own we're now starting to build the page it will link to; a view of the bill licence and all its transactions.
This adds a presenter that given a
TransactionModelinstance whose charge type isminimum_chargewill return an object containing formatted details about the transaction.The presenter doesn't need to make any distinction between PRESROC and SROC transactions as they are both displayed in the same way.