Linking 2PT SROC review page #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4205 This pull request is preparing to create a new page for reviewing 2PT SROC bill runs. In the UI repo, changes have been made to redirect requests from links on the billing and batch list page that are related to 2PT SROC bill runs. These requests will now redirect to the new page in the system's repo.
Beckyrose200
changed the title
Cruikshanks
requested changes
Nov 7, 2023
Cruikshanks
approved these changes
Nov 8, 2023
Cruikshanks
added a commit
that referenced
this pull request
Nov 22, 2023
https://eaflood.atlassian.net/browse/WATER-4205 In [Linking 2PT SROC review page](#504) we added a stand-in view to confirm that if you click a bill run in `REVIEW` in the bill runs page of the internal UI you will get to a page we intend to build out and supporting reviewing the match & allocate results. What we should have spotted is that the template was named `view.njk` not `review.njk`. We need `view.njk` as that would be the default template name for viewing a bill run. So, this quick change renames the template to `review.njk` to match the controller name and endpoint.
Cruikshanks
added a commit
that referenced
this pull request
Nov 22, 2023
https://eaflood.atlassian.net/browse/WATER-4205 In [Linking 2PT SROC review page](#504) we added a stand-in view to confirm that if you click a bill run in `REVIEW` in the bill runs page of the internal UI you will get to a page we intend to build out and supporting reviewing the match & allocate results. What we should have spotted is that the template was named `view.njk` not `review.njk`. We need `view.njk` as that would be the default template name for viewing a bill run. So, this quick change renames the template to `review.njk` to match the controller name and endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4205
This pull request is preparing to create a new page for reviewing 2PT SROC bill runs. In the UI repo, changes have been made to redirect requests from links on the billing and batch list page that are related to 2PT SROC bill runs. These requests will now redirect to the new page in the system's repo.