Handle create 2PT bill run requests #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4204 We need to update the validation logic used that checks the incoming request to accept an optional start and end year for 2PT requests. We then need to pass this information down to our `app/services/billing/start-bill-run-process.service.js`. The logic in that service will need to be updated to handle both 2PT and supplementary bill runs. For example, it assumes there will be multiple building periods calculated from the current year. For 2PT it will only be the current year, else the financial year provided in the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4204
We need to update the validation logic used that checks the incoming request to accept an optional start and end year for 2PT requests. We then need to pass this information down to our
app/services/billing/start-bill-run-process.service.js.The logic in that service will need to be updated to handle both 2PT and supplementary bill runs. For example, it assumes there will be multiple building periods calculated from the current year. For 2PT it will only be the current year, else the financial year provided in the request.