Refactor Hapi-pino logger to clean things up #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First tweak is around config. We were pulling it into our main `app/server.js` and `HapiPinoIgnoreRequestService`. This meant we also needed to stub the config to get tests working for the `HapiPinoIgnoreRequestService`. By moving the config into the plugin we can use it where its needed, and ensure it gets passed through as an arg. This means `LogConfig` is now only referenced in one place and we can remove the stubbing in our `HapiPinoIgnoreRequestService` tests because we're passing the critical option through. The second was a mix of conventions. We were using a separate service to contain the logic of whether a request should be logged but a function in the plugin to covere logging in tests. By moving the logging in tests logic to a service we get consistency _and_ we can write some unit tests to cover it.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first tweak is around config. We were pulling it into our main
app/server.jsandHapiPinoIgnoreRequestService. This meant we also needed to stub the config to get tests working for theHapiPinoIgnoreRequestService. By moving the config into the plugin we can use it where it's needed, and ensure it gets passed through as an arg. This meansLogConfigis now only referenced in one place and we can remove the stubbing in ourHapiPinoIgnoreRequestServicetests because we're passing the critical option through.The second was a mix of conventions. We were using a separate service to contain the logic of whether a request should be logged but a function in the plugin to cover logging in tests. By moving the logging in tests logic to a service we get consistency and we can write some unit tests to cover it.