Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing links to page footer #473

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Conversation

Cruikshanks
Copy link
Member

@Cruikshanks Cruikshanks commented Oct 19, 2023

https://eaflood.atlassian.net/browse/WATER-4155

We are building our first proper page which will replace something the water-abstraction-ui currently handles.

But before we get into the meat of it we've spotted that the footer is missing links to our cookies, privacy and accessibility pages.

This change rectifies that.

Screenshot of links Screenshot 2023-10-19 at 19 02 04

https://eaflood.atlassian.net/browse/WATER-4155

We are building our first proper page which will replace something the [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui) currently handles.

But before we get into the meat of it we've spotted that the footer is missing links to our cookies, privacy and accessibility pages.

This change rectifies that.
@Cruikshanks Cruikshanks added the housekeeping Refactoring, tidying up or other work which supports the project label Oct 19, 2023
@Cruikshanks Cruikshanks self-assigned this Oct 19, 2023
This is a straight copy from the legacy UI. If using them locally bear in mind all system pages are expected to be rendered via the existing UI. So, go to <http://localhost:8008/system/health/info> and the links will work. Go to <http://localhost:8013/health/info> and they won't.
@Cruikshanks Cruikshanks marked this pull request as ready for review October 19, 2023 18:20
@Cruikshanks Cruikshanks merged commit ca3765d into main Oct 20, 2023
4 checks passed
@Cruikshanks Cruikshanks deleted the add-missing-links-to-footer branch October 20, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants