Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create migration script, model, helper and unit tests for licence_versions #456

Merged
merged 8 commits into from
Oct 10, 2023

Conversation

Jozzey
Copy link
Contributor

@Jozzey Jozzey commented Oct 9, 2023

https://eaflood.atlassian.net/browse/WATER-3486

Whilst working on the unit tests for the enhancement in this PR #443 it was found that we would need the migration script, model, helper and unit tests for table licence_versions.

These will be created in this PR.

https://eaflood.atlassian.net/browse/WATER-3486

Whilst working on the unit tests for the enhancement in this PR #443 it was found that we would need the migrations, model, helper and unit tests for table `licence_versions`.

These will be created in this PR.
@Jozzey Jozzey added the enhancement New feature or request label Oct 9, 2023
@Jozzey Jozzey self-assigned this Oct 9, 2023
@Jozzey Jozzey marked this pull request as ready for review October 9, 2023 18:31
Copy link
Contributor

@Beckyrose200 Beckyrose200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 comment from me :)

test/support/helpers/water/licence-version.helper.js Outdated Show resolved Hide resolved
@Jozzey Jozzey requested a review from Beckyrose200 October 10, 2023 08:59
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we'll need a final tweak before this gets merged 😁

test/support/helpers/water/licence-version.helper.js Outdated Show resolved Hide resolved
@Jozzey Jozzey requested a review from Cruikshanks October 10, 2023 09:55
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/support/helpers/water/licence-version.helper.js Outdated Show resolved Hide resolved
Co-authored-by: Alan Cruikshanks <[email protected]>
@Jozzey Jozzey requested a review from Cruikshanks October 10, 2023 10:02
@Jozzey
Copy link
Contributor Author

Jozzey commented Oct 10, 2023

I'll get there eventually 😄

@Jozzey Jozzey merged commit 96dcb9d into main Oct 10, 2023
6 checks passed
@Jozzey Jozzey deleted the setup-licence-versions-table branch October 10, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants