Change where the allocated Return volume is held #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4127 In a previous PR #436 which dealt with allocating the Return volumes to Charge Elelemts. It was assumed that the `billableAnnualQuantity` data item could be used to hold the Return volumes allocated to a Charge Element. However, in a very few cases this could already contain data which will cause the Return volume allocation process to not work properly. Therefore this PR will create a new data item on the Charge Element called `allocatedReturnVolume` that will be used to hold any Return volumes allocated to a particular Charge Element.
Cruikshanks
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4127
In a previous PR #436 which dealt with allocating the Return volumes to Charge Elements. It was assumed that the
billableAnnualQuantitydata item could be used to hold the Return volumes allocated to a Charge Element. However, in very few cases, this could already contain data which will cause the Return volume allocation process to not work properly.Therefore this PR will create a new data item on the Charge Element called
allocatedReturnVolumethat will be used to hold any Return volumes allocated to a particular Charge Element.