Add support for alias to Legacy Models #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#97 We hit a snag as part of the **Great Rename**! We want `water.charge_elements` to be `ChargeReferences`. We then want `water.charge_purposes` to be `ChargeElements`. But there is a relationship between the 2 that has to be defined in `ChargeReferenceModel`. The problem is when you run `const query = await ChargeReferenceModel.query().innerJoinRelated('chargeElements')` you get an error from [Objection.js](https://vincit.github.io/objection.js). ``` select "charge_elements".* from "water"."charge_elements" inner join "water"."charge_purposes" as "charge_elements" on "charge_elements"."charge_element_id" = "charge_elements"."charge_element_id" - table name "charge_elements" specified more than once ``` If we can get Objection to alias `charge_elements` as `charge_references` in our query then we would remove the error. To do this we need to use `alias()` in the custom query builder used by the model. Currently, all our models extend `LegacyBaseModel` which uses `SchemaQueryBuilder` to ensure all legacy models apply a schema. This change refactors `SchemaQueryBuilder` to also handle applying a table alias when one exists.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#97
We hit a snag as part of the Great Rename!
We want
water.charge_elementsto beChargeReferences. We then wantwater.charge_purposesto beChargeElements. But there is a relationship between the 2 that has to be defined inChargeReferenceModel.The problem is when you run
const query = await ChargeReferenceModel.query().innerJoinRelated('chargeElements')you get an error from Objection.js.If we can get Objection to alias
charge_elementsascharge_referencesin our query then we would remove the error. To do this we need to usealias()in the custom query builder used by the model. Currently, all our models extendLegacyBaseModelwhich usesSchemaQueryBuilderto ensure all legacy models apply a schema.This change refactors
SchemaQueryBuilderto also handle applying a table alias when one exists.