Amend the supplementary charge version query #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3826 The query as we have it is to simplistic. We need to review all charge versions within a given financial year to accurately calculate the bill run. We can't just look at the 'current' charge version. So, this change updates the query to consider the creation and effective dates for the charge versions linked to a licence.
Start date becomes a consideration in our query so we need to add it to the table.
We now pass through the billing period in order to use it in our query. We've not yet updated the tests (other than to ensure we pass through a billing period) in order to highlight as expected they fail.
Without the context some of the changes look 'odd'! So, we've added some comments to help make sense of things.
Now it's a critical factor in our query we should be outputting the start date to make it easier to confirm the results are correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3826
The query as we have it is too simplistic. We need to review all charge versions within a given financial year to accurately calculate the bill run. We can't just look at the 'current' charge version.
So, this change updates the query to consider the start date (effective date) for the charge versions linked to a licence in conjunction with the billing period.
** Note
We're still working on our understanding of what is required when generating a supplementary bill run. At the moment the functionality is more about confirming we're selecting the right things rather than getting on with generating a bill run.
So, what we have will not be the finished version.