Standardise how model helpers generate dates #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have spotted some inconsistency in how our model test helpers are adding dates. Some are using just text for the date as other are creating actual dates using `new Date()`. This PR will ensure that all helpers are using the `new Date()` method to populate thier dates.
Jozzey
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have spotted some inconsistency in how our model test helpers are populating dates. Some are using just text for the date and others are creating actual dates using
new Date().This PR will ensure that all helpers are using the
new Date()method to populate their dates.There are also some helpers that are not correctly creating their timestamps so these will also be fixed in this PR.