Fix tests for new dev environment #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#64 Having built a new development environment based on Docker and Docker Compose that allows us to setup and maintain WRLS on Apple M1 Mac's we've hit some further issues. A number of the repos have it had coded into the tests to assume everything is always running on `http://localhost`. When it comes to our new Docker environment though, the Addressbase Facade and the Charge Module aren't anymore. When it comes to this repo, the other assumption is that the machine the app is running on has the redis CLI installed. In our new dev environment that isn't the case, and shouldn't be assumed in our AWS environments. So, this change - fixes unit tests not to depend on hard coded urls - makes the redis based tests pending (we'll tackle those properly once we have implemented redis support)
Cruikshanks
added
the
housekeeping
Jozzey
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#64
Having built a new development environment based on Docker and Docker Compose that allows us to set up and maintain WRLS on Apple M1 Mac's we've hit some further issues. A number of the repos have it had coded into the tests to assume everything is always running on
http://localhost. When it comes to our new Docker environment though, the Addressbase Facade and the Charge Module aren't anymore.When it comes to this repo, the other assumption is that the machine the app is running on has the Redis CLI installed. In our new dev environment that isn't the case, and shouldn't be assumed in our AWS environments.
So, this change