Update billing-accounts ctrlr to validate request #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4092 We are working on migrating the change billing account address functionality from the legacy code to this project. We've previously added a new endpoint and controller that the UI will start using instead of the legacy one. But it is only a dummy, just returning a `201` in response to requests. This change adds the [new change address validator](#383) to the controller. It will mean the controller can validate the incoming requests and handle errors resulting from invalid data. A future final step will add in a new `ChangeAddressService`.
Jozzey
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4092
We are working on migrating the change billing account address functionality from the legacy code to this project.
We've previously added a new endpoint and controller that the UI will start using instead of the legacy one. But it is only a dummy, just returning a
201in response to requests.This change adds the new change address validator to the controller. It will mean the controller can validate the incoming requests and handle errors resulting from invalid data.
A future final step will add in a new
ChangeAddressService.