Skip to content

Housekeeping for create bill run validator #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Housekeeping for create bill run validator #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e075356
Housekeeping for create bill run validator
Cruikshanks Aug 29, 2023
060dacb
Fix incorrect test file name
Cruikshanks Aug 25, 2023
de4feae
Move existing validator
Cruikshanks Aug 25, 2023
0123a4f
Fix broken reference
Cruikshanks Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/bill-runs.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

const Boom = require('@hapi/boom')

const CreateBillRunValidator = require('../validators/bill-runs/create-bill-run.validator.js')
const CreateBillRunValidator = require('../validators/create-bill-run.validator.js')
const NewBillingBatchService = require('../services/billing/new-billing-batch.service.js')

async function create (request, h) {
Expand Down
2 changes: 1 addition & 1 deletion ...rs/bill-runs/create-bill-run.validator.js → app/validators/create-bill-run.validator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

const Joi = require('joi')

const StaticLookupsLib = require('../../lib/static-lookups.lib.js')
const StaticLookupsLib = require('../lib/static-lookups.lib.js')

/**
* Checks that the payload of a `create bill run` request is valid
Expand Down
2 changes: 1 addition & 1 deletion ...rs/bill-runs/create-bill-run.validator.js → ...idators/create-bill-run.validator.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const { describe, it } = exports.lab = Lab.script()
const { expect } = Code

// Thing under test
const CreateBillRunValidator = require('../../../app/validators/bill-runs/create-bill-run.validator.js')
const CreateBillRunValidator = require('../../app/validators/create-bill-run.validator.js')

describe('Create Bill Run validator', () => {
describe('when valid data is provided', () => {
Expand Down