-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create idm
migrations for authentication plugin
#384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4085 In anticipation of developing our [authentication plugin](#351) we create migrations to set up our test db with the idm schema and required tables.
Cruikshanks
approved these changes
Aug 25, 2023
Jozzey
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 1 issue with a primary key being wrong
.withSchema('idm') | ||
.createTable(tableName, (table) => { | ||
// Primary Key | ||
table.string('user_id').primary().notNullable() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary key on this table should be group_role_id
Cruikshanks
added a commit
that referenced
this pull request
Sep 4, 2023
https://eaflood.atlassian.net/browse/WATER-4085 We are always doing this! 🤦 In [Create idm migrations for authentication plugin](#384) we added migrations to create the `idm` schema and some tables. But we forgot to include the schema in our DatabaseHelper. Doh!
Cruikshanks
added a commit
that referenced
this pull request
Sep 5, 2023
https://eaflood.atlassian.net/browse/WATER-4085 We are always doing this! 🤦 In [Create idm migrations for authentication plugin](#384) we added migrations to create the `idm` schema and some tables. But we forgot to include the schema in our DatabaseHelper. Doh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4085
In anticipation of developing our authentication plugin we create migrations to set up our test db with the
idm
schema and required tables.