Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create idm migrations for authentication plugin #384

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

StuAA78
Copy link
Contributor

@StuAA78 StuAA78 commented Aug 25, 2023

https://eaflood.atlassian.net/browse/WATER-4085

In anticipation of developing our authentication plugin we create migrations to set up our test db with the idm schema and required tables.

https://eaflood.atlassian.net/browse/WATER-4085

In anticipation of developing our [authentication plugin](#351) we create migrations to set up our test db with the idm schema and required tables.
@StuAA78 StuAA78 added the enhancement New feature or request label Aug 25, 2023
@StuAA78 StuAA78 self-assigned this Aug 25, 2023
@StuAA78 StuAA78 marked this pull request as ready for review August 25, 2023 13:16
@StuAA78 StuAA78 merged commit 3a06739 into main Aug 25, 2023
@StuAA78 StuAA78 deleted the create-migrations-for-authentication-plugin branch August 25, 2023 13:39
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 1 issue with a primary key being wrong

.withSchema('idm')
.createTable(tableName, (table) => {
// Primary Key
table.string('user_id').primary().notNullable()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary key on this table should be group_role_id

Cruikshanks added a commit that referenced this pull request Sep 4, 2023
https://eaflood.atlassian.net/browse/WATER-4085

We are always doing this! 🤦

In [Create idm migrations for authentication plugin](#384) we added migrations to create the `idm` schema and some tables. But we forgot to include the schema in our DatabaseHelper. Doh!
Cruikshanks added a commit that referenced this pull request Sep 5, 2023
https://eaflood.atlassian.net/browse/WATER-4085

We are always doing this! 🤦

In [Create idm migrations for authentication plugin](#384) we added migrations to create the `idm` schema and some tables. But we forgot to include the schema in our DatabaseHelper. Doh!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants