Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New billing batch record for SROC supplementary bill run #37

Merged
merged 21 commits into from
Dec 9, 2022

Conversation

Jozzey
Copy link
Contributor

@Jozzey Jozzey commented Nov 25, 2022

https://eaflood.atlassian.net/browse/WATER-3830

We are starting to create the initial records needed in the SROC Supplementary process.

The first is the billing_batch record. Users can view the status of a bill run on the bill runs page. We need this record to support this, plus link/record other values, for example, the charge module’s Bill run ID.

https://eaflood.atlassian.net/browse/WATER-3830

 We are starting to create the initial records needed in the SROC Supplementary process.

The first is the billing_batch record. Users can view the status of a bill run on the bill runs page. We need this record to support this, plus link/record other values, for example, the charge module’s Bill run ID.
@Jozzey Jozzey added the enhancement New feature or request label Nov 25, 2022
@Jozzey Jozzey self-assigned this Nov 25, 2022
@Jozzey
Copy link
Contributor Author

Jozzey commented Dec 8, 2022

I've created a billing-batch test helper but ended up not using it as the billing batch service creates a billing batch so didn't need the helper to do it for me.

I've left the helper in for the time being in case we need it later on, but let me know if you'd like it removed.

@Jozzey Jozzey marked this pull request as ready for review December 8, 2022 18:21
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a real minor change. Over than that, this is bang on the money!

app/models/region.model.js Outdated Show resolved Hide resolved
@Jozzey Jozzey requested a review from Cruikshanks December 9, 2022 09:09
@Jozzey Jozzey merged commit 0aeb69e into main Dec 9, 2022
@Jozzey Jozzey deleted the new-billing-batch-record-for-SROC-supp-bill-run branch December 9, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants