Determine returns matching status for licence #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4079 This PR will add a new `returnsMatchingStatus` data item to the Two Part Tariff algorithms output. This is calculated as follows: - No matching returns then mark as `error` - A return status is `UNDER QUERY` then mark as `error` - A return status is `NOT KEYED` then mark as `error` - A return status is `DUE` then mark as `ready` - A return status is `COMPLETE` then mark as `ready` When there are no matching returns the `returnStatuses` will be set to `Unable to match return`
Cruikshanks
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4079
This PR will add a new
returnsMatchingStatusdata item to the Two Part Tariff algorithms output. This is calculated as follows:errorUNDER QUERYthen mark aserror(this is a boolean in thereturnstable)NOT KEYEDthen mark aserror(assumption made this is thereceivedstatus in thereturnstable)DUEthen mark asreadyCOMPLETEthen mark asreadyThere is also a possible return status of
void, this will also mark aserror.