Get Return Status as part of Matching Algorithm #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4081 As a billing and data user, I need the status of the returns to be assessed. Once the charge element is matched to a return, the next step is to assess the status of the return, so that the relevant volumes and status can be recorded or error recorded. This PR adds a new `returnStatus` array to the `chargeVersions` object displaying the unique statuses of the returns matched to the charge version.
Cruikshanks
requested changes
Aug 16, 2023
Cruikshanks
added a commit
that referenced
this pull request
Aug 17, 2023
https://eaflood.atlassian.net/browse/WATER-4081 After the changes made in [Get Return Status as part of Matching Algorithm](#360) we need to update the 'friendly' response the two-part tariff `/check` endpoint returns. Namely, matched returns have been moved back to be assigned against the matching charge element (charge reference in the friendly response). And the return statuses are now a distinct array of statues for all returns matched within a charge version (charge information).
Cruikshanks
added a commit
that referenced
this pull request
Aug 17, 2023
https://eaflood.atlassian.net/browse/WATER-4081 After the changes made in [Get Return Status as part of Matching Algorithm](#360) we need to update the 'friendly' response the two-part tariff `/check` endpoint returns. Namely, matched returns have been moved back to be assigned against the matching charge element (charge reference in the friendly response). And the return statuses are now a distinct array of statuses for all returns matched within a charge version (charge information).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4081
As a billing and data user, I need the status of the returns to be assessed.
Once the charge element is matched to a return, the next step is to assess the status of the return, so that the relevant volumes and status can be recorded or error recorded.
This PR adds a new
returnStatusarray to thechargeVersionsobject displaying the unique statuses of the returns matched to the charge version.