TPT testing scenarios fixes #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4078 During testing of the new SROC Two Part Tariff functionality some issues have been raised that will be addressed in this PR. These issues are: - Exclude licences that are in workflow/review/setup - Exclude licences that have a TPT CV replaced with non TPT CV - Replaced TPT CVs
Previously we were selecting all charge versions except for ones with a `status` of `draft`. This meant we were also returning `superseeded` CVs. Query now updated to only fetch 'current' CVs
Cruikshanks
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4078
During testing of the new SROC Two Part Tariff functionality, some issues have been raised that will be addressed in this PR.
These issues are: