Add new data formatters to base presenter #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4070 https://eaflood.atlassian.net/browse/WATER-4073 Whilst working on [Create endpoint to generate fake data](#347) we added a number of formatters. These take data from the DB and re-format them to match how the UI displays the values. We believe we are going to need these formatters in future changes we'll be making, the first of which is a re-designed bill run page. So, to help prepare for that we are adding those formatters to our `BasePresenter` so they are available to any future presenters we add.
Now we have added a second and will likely add more we decided a formatter with a 'generic' name would be confusing.
This one is a little different in that abstraction dates are not held as dates, but as a day and month. You add the year when you need to calculate the abstraction period.
In the bill run page when looking at the transaction detail the period needs to be formatted in this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4070
https://eaflood.atlassian.net/browse/WATER-4073
Whilst working on Create endpoint to generate fake data we added a number of formatters. These take DB data and re-format it to match how the UI displays the values.
We will need these formatters in future changes we'll be making, the first of which is a re-designed bill run page.
So, to help prepare for that we are adding those formatters to our
BasePresenterso they are available to any future presenters we add.